-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CommandInteraction): add toString method #6793
Merged
iCrawl
merged 2 commits into
discordjs:main
from
ImRodry:feat-commandinteraction-tostring
Oct 12, 2021
Merged
feat(CommandInteraction): add toString method #6793
iCrawl
merged 2 commits into
discordjs:main
from
ImRodry:feat-commandinteraction-tostring
Oct 12, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jiralite
reviewed
Oct 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Can we put this in the command interaction option resolver so context menu commands can utilise this too (as well as autocomplete when it is released)?
- If nearly all the checks stem from the command interaction option resolver, you might as well move it into there and have this method call it from there. This can deduplicate code if you go with the aforementioned point.
ckohen
reviewed
Oct 8, 2021
|
kyranet
approved these changes
Oct 8, 2021
vladfrangu
approved these changes
Oct 11, 2021
iCrawl
approved these changes
Oct 12, 2021
SpaceEEC
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR adds a toString method to CommandInteraction that outputs a string that can be copied by a user in order to execute the same command again. There’s an upcoming update to the client text editor so I’m not sure how this will work once that’s out but this works fine at the moment
Example:
Status and versioning classification: